Open
Conversation
- Rename all header files with "tapp_" prefix. This will help prevent problems when users do something like `#include "tapp_XXX.h"` with `-I/path/to/tapp/tapp`. - Remove some old discussion and proposal files.
janbrandejs
reviewed
Jul 2, 2025
Contributor
There was a problem hiding this comment.
I think this would be an efficient scheme which we could potentialy require anytime when the interface itself is changed in multiple places:
- there is a pull request on tapp interface itself
- reviewer thinks it's a good idea
- put the suggested changes on a branch in reference implentation
- test passed (pipeline test++?) -> you can merge in master there without a review
- the pull request to tapp itself can be approved
Collaborator
Author
|
Yes definitely any changes should go through CI and the ref. implementation is a good place for that. I need to make sure we are starting from 1:1 on the interface defined here and implemented in the reference. |
Collaborator
Author
|
Just a couple more PRs here then I'll work on that flow :). |
Collaborator
Author
|
Except, I'm not sure about steps 1 and 2 since that will be a lot more work for maintainers. Perhaps it would be good to keep development (including interface) on the reference implementation master branch and then group updates atomically into new versions of the official interface. |
Contributor
|
Excellent idea! |
pauldj
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#include "tapp_XXX.h"with-I/path/to/tapp/tapp.